Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padronize vulture and pylint #2259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

VindeeR
Copy link
Contributor

@VindeeR VindeeR commented Apr 2, 2025

Creating files to standardize the vulture and pylint configurations

@VindeeR VindeeR added the enhancement New feature or request label Apr 2, 2025
@VindeeR VindeeR requested a review from isimo00 April 2, 2025 10:17
@VindeeR VindeeR self-assigned this Apr 2, 2025
@VindeeR VindeeR linked an issue Apr 2, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.33%. Comparing base (f58790c) to head (8eb4f5e).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2259      +/-   ##
==========================================
+ Coverage   52.22%   55.33%   +3.10%     
==========================================
  Files          71       72       +1     
  Lines       17617    17232     -385     
  Branches     3417     3350      -67     
==========================================
+ Hits         9201     9535     +334     
+ Misses       7613     6859     -754     
- Partials      803      838      +35     
Flag Coverage Δ
fast-tests 55.33% <ø> (+3.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@isimo00
Copy link
Contributor

isimo00 commented Apr 2, 2025

Can you add a description please? :)

asyncSetUp,
__post_init__

# List of member names, which should be excluded from the protected access
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to this commented on #2284
fyi @kinow
I think that we shouldn't have complaints about protected stuff in test methods, as they may require us to modify where they're pointing to ( or we just need to test them )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitelist for vulture
4 participants