Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate scripts and python package #238

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Consolidate scripts and python package #238

merged 6 commits into from
Sep 30, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Sep 26, 2024

  • some functionality from scripts/ would be useful inside the library
  • some functionality from the library was replicated in scripts/

-> consolidate (see also #208), turn separate scripts into entrypoints (currently prefixed with bmp- from Benchmark-Models-Petab)

* some functionality from scripts/ would be useful inside the library
* some functionality from the library was replicated in scripts/
-> consolidate, turn separate scripts into entrypoints

* Reduce number of package configuration files
@dweindl dweindl marked this pull request as ready for review September 26, 2024 10:36
@dweindl dweindl self-assigned this Sep 26, 2024
Copy link
Collaborator

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the many improvements! I checked the bmp-* commands locally 👍

Could add from .overview import get_overview_df to __init__, and for the other commands too, but fine as-is for me. At the moment there is no documentation, but if it's in __init__ then it's a bit more findable.

@dweindl
Copy link
Member Author

dweindl commented Sep 30, 2024

Could add from .overview import get_overview_df to __init__, and for the other commands too, but fine as-is for me. At the moment there is no documentation, but if it's in __init__ then it's a bit more findable.

Did it for get_overview_df. The rest can wait until after further cleanup and better documentation.

@dweindl dweindl merged commit 61d4f03 into master Sep 30, 2024
6 checks passed
@dweindl dweindl deleted the consolidate_py branch September 30, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend overview table: priors Machine readable model property overview
2 participants