Download validation results, include timestamp and version #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-add previously existing download feature. Use the location header as part of the results.
The result file name contains the input file name. The extension is removed from the input file name. If the resulting length is trimmed to 170 characters so that the final file name is short enough to be opened in Excel.
shaselton-usds
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download validation results, include timestamp and version
Problem
Validator output lacks useful contextual information, such as time that the validator was run. Additionally, it is difficult to save results in a text-based format.
Solution
Add start time, end time, and
hpt-validatorversion to web display of results. Add a button to download a results file. The results file contains the new contextual information above the list of errors.Test Plan
Run the hpt-tool site locally and use the online validator. Confirm that start and end time are displayed as part of the results. Confirm that the current
hpt-validatorversion is displayed as part of the results. This version should be1.10.0at time of writing. Use the new button to download the result file. Confirm that the result file contains the same information as displayed in the web results. Confirm that the downloaded result file is named based on the input file name.