Replacing deprecated max_connections with max_listen_connections #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This symbol has been deprecated since at least 1.74, and is removed in 1.87
kheaactua
force-pushed
the
boost_max_connections
branch
from
a1f7eab to
9ffa989
Compare
|
We have an internal draft pr with boost 1.87.0 compatibility that includes this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This symbol has been deprecated since at least 1.74, and is removed in 1.87.
Replacing it with
max_listen_connectionsas recommended here: https://beta.boost.org/doc/libs/1_86_0/doc/html/boost_asio/reference/socket_base.htmlBoth these symbols are available in 1.66 so this shouldn't have an impact on backwards compatibility
Notes
asio::io_context::post was also removed - it was deprecated even in 1.66. The recommended alternative is asio::io_context::post(ctx) - I'll deal with this in another PR