Skip to content

Add inelastic power loss to PlasmaPhase #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BangShiuh
Copy link
Contributor

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

Closes #

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@BangShiuh BangShiuh marked this pull request as draft April 13, 2025 02:44
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.36%. Comparing base (acf3f0e) to head (24bbab2).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
include/cantera/kinetics/Kinetics.h 0.00% 2 Missing ⚠️
src/thermo/PlasmaPhase.cpp 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   74.80%   74.36%   -0.44%     
==========================================
  Files         387      443      +56     
  Lines       53938    55435    +1497     
  Branches     9105     9108       +3     
==========================================
+ Hits        40346    41226     +880     
- Misses      10503    11110     +607     
- Partials     3089     3099      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants