Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change content on how to use the service #5089

Merged
merged 12 commits into from
Mar 31, 2025

Conversation

joegibb
Copy link
Contributor

@joegibb joegibb commented Mar 26, 2025

Context

The dates for rollover are being changed to September and this needs to be reflected in the content on how to use this service.

@joegibb joegibb requested a review from a team as a code owner March 26, 2025 15:25
@joegibb joegibb added the deploy A Review App will be created for PRs with this label label Mar 26, 2025
Copy link

@gms-gs
Copy link
Contributor

gms-gs commented Mar 27, 2025

@joegibb Can these be put into translations files please. Other than that looks good

Copy link
Contributor

@inulty-dfe inulty-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stick to rollover or roll_over. Only one file in the codebase has roll_over so rollover is preferred.

@inulty-dfe
Copy link
Contributor

Would you mind renaming roll_over_courses_to_a_new_recruitment_cycle.html.erb changing it to rollover_courses_to_a_new_recruitment_cycle.html.erb while we're here please?

@joegibb joegibb merged commit 4ddcf72 into main Mar 31, 2025
34 checks passed
@joegibb joegibb deleted the change-content--on-roll-over-design-history branch March 31, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants