Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we smart quotes provider name before saving into the DB #5090

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Make sure we smart quotes provider name before saving into the DB #5090

merged 1 commit into from
Mar 31, 2025

Conversation

tomas-stefano
Copy link
Contributor

@tomas-stefano tomas-stefano commented Mar 26, 2025 •
edited
Loading

Context

On our search results, providers which has single quotes on their names are not displaying smart quotes.

We should make sure smart quotes are saved into the database instead of changing on the presentation layer.

Changes proposed in this pull request

  • Normalize the provider name attribute

Guidance to review

  1. When you save does the provider name is converted properly?

@tomas-stefano tomas-stefano added the deploy A Review App will be created for PRs with this label label Mar 26, 2025
@github-actions GitHub Actions
Copy link

Deployments

App URL
Publish https://publish-review-5090.test.teacherservices.cloud
Find https://find-review-5090.test.teacherservices.cloud

@tomas-stefano tomas-stefano force-pushed the td/593-smart-quotes-on-provider-name-on-search-results branch from c5f6408 to 714fef3 Compare March 26, 2025 17:11
@tomas-stefano tomas-stefano force-pushed the td/593-smart-quotes-on-provider-name-on-search-results branch from 714fef3 to 1a6ebca Compare March 26, 2025 17:18
@tomas-stefano tomas-stefano marked this pull request as ready for review March 27, 2025 09:57
@tomas-stefano tomas-stefano requested a review from a team as a code owner March 27, 2025 09:57
@tomas-stefano
Copy link
Contributor Author

https://trello.com/c/YY71CfYi/593-smart-quotes-on-provider-name-on-search-results

@tomas-stefano
Copy link
Contributor Author

The autocomplete works as expected around single and smart quotes too

Screenshot 2025-03-26 at 16 42 15

inulty-dfe
inulty-dfe reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@inulty-dfe inulty-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're sure we'll never want the school name to be "unsmart" quoted?

@tomas-stefano
Copy link
Contributor Author

We're sure we'll never want the school name to be "unsmart" quoted?

If we need we can make "unsmart" which could be the exception rather than the rule.

@tomas-stefano tomas-stefano force-pushed the td/593-smart-quotes-on-provider-name-on-search-results branch from 1a6ebca to 8191d7c Compare March 31, 2025 09:10
@tomas-stefano tomas-stefano merged commit 2e8b7ec into main Mar 31, 2025
34 checks passed
@tomas-stefano tomas-stefano deleted the td/593-smart-quotes-on-provider-name-on-search-results branch March 31, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inulty-dfe inulty-dfe inulty-dfe approved these changes

Assignees
No one assigned
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomas-stefano @inulty-dfe