Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Use SetUpTestSuite to get a package id that is used in a testsuite #1477

Open
wants to merge 5 commits into
base: bugfix-vtk_reader_data
Choose a base branch
from

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Mar 13, 2025

This PR implements a solution that I proposed for #1431 . It provides the package id only to testsuites that need it, testsuites can not interfer with the package id and it uses one package_id per testsuite.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

Tag Label

  • The author added the patch/minor/major label in accordance to semantic versioning.

License

  • The author added a BSD statement to doc/ (or already has one).

@Davknapp Davknapp changed the title Use SetUpTestSuite to get a package id that is used in a testsuite Improvement: Use SetUpTestSuite to get a package id that is used in a testsuite Mar 26, 2025
@sandro-elsweijer sandro-elsweijer force-pushed the bugfix-vtk_reader_data branch from 9b55ba0 to 7321333 Compare April 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants