-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional machine details to query_config
#4759
Conversation
"features": { | ||
"ghcr.io/devcontainers/features/git:1": {} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these container changes part of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yea I'll pull that out and make a separate PR. It's some additional dev stuff for anyone using vscode to simplify running/testing in a container locally. @jedwards4b @jgfouca Any issue if I add this in a different PR? It doesn't affect anything unless you're using vscode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't care if you keep it in this PR as long as we understand why it's there and you add it to the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to pull it out of this PR. I'll be making a more testing focused PR soon, it'll fit in better there and I can provide a full explanation.
I tried "./query_config --machines chrysalis --compiler intel" and it looks good! "./query-config --machines" is a valid input. People might try "./query-config --machines --compiler intel" but I think we should restrict "--compiler" to specific machines. Current it gives a python error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we just need to answer Rob's question and then we can merge.
@jasonb5 did you also see #4759 (comment) ? |
@rljacob Just need to make sure I fully understand the change you'd like to see; there should be a error message rather than the exception when a user provides |
Yes there should be an error message in that case. |
@rljacob Changed the behavior, now it will print the usage with this error message |
Adds
--compiler
argument toquery_config
. This argument shouldbe used when querying a specific machine e.g.
--machines frontier
.When specified,
modules
andenvironment_variables
that match thecompiler will be printed. Additional requirements e.g.
DEBUG="TRUE"
will be printed above sections that require them. Additionally for
environment_variables
there is an attempt to resolve any CIME specifictemplates e.g.
$ENV{HOME}
.Test suite:
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a
Fixes #4743
User interface changes?:
Update gh-pages html (Y/N)?: