[NFC] Eliminate the "W" form of clang-tidy warnings #4438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
refactoring 😡 ➡️ 🙂
cservakt
reviewed
Feb 3, 2025
Comment on lines
251
to
256
| __warning_blacklist = { | ||
| # It is a parameterized checker and there is no infrastructure to | ||
| # provide a parameter for a checker. | ||
| 'frame-larger-than', | ||
| 'frame-larger-than=' | ||
| } |
There was a problem hiding this comment.
I am not sure it is the best way to list these blacklisted warnings. Can we add a prop to labels that is a status of the backlist?
Earlier "clang-diagnostic-..." checkers could have been provided with their original "W" warning flag form. For example Wformat vs. clang-diagnostic-format. The "W" form is deprecated for a while and the late CodeChecker versions emit a hard error when using them. For this reason there is no need to distinguish "W" form as a warning anymore.
bruntib
force-pushed
the
warning_flags
branch
from
15cf9df to
ed86a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier "clang-diagnostic-..." checkers could have been provided with their original "W" warning flag form. For example Wformat vs. clang-diagnostic-format. The "W" form is deprecated for a while and the late CodeChecker versions emit a hard error when using them. For this reason there is no need to distinguish "W" form as a warning anymore.