CI: update Docker toolchain images with pre-populated Conan caches #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistafunk
commented
Mar 18, 2025
afrischknecht
requested changes
Mar 26, 2025
There was a problem hiding this comment.
Interesting approach, baking the dependencies directly into the tools image! On the pro-side, it will make reproducible builds much easier, on the downside, more frequent rebuilds of the images might be required.
In any case, since the HDK (and therefore the resulting image) is rather large, avoid including unnecessary hidden copies in different layers. (See my comments re COPY vs. RUN with temporary bind-mounts.)
mistafunk
force-pushed
the
shaegler/docker-windows
branch
from
57a1228 to
327e98f
Compare
this is a preparation step to inline the Conan setup into the Docker toolchain image
this is a preparatory step to inline the conan packages into the toolchain container
mistafunk
force-pushed
the
shaegler/docker-inline-conan
branch
2 times, most recently
from
697f271 to
7b268a3
Compare
mistafunk
force-pushed
the
shaegler/docker-inline-conan
branch
2 times, most recently
from
d970ce1 to
5f21db6
Compare
also deduplicate the task configuration pipline code
split into two stages as we need different host build contexts (windows container build does not support --build-context)
mistafunk
force-pushed
the
shaegler/docker-inline-conan
branch
from
5f21db6 to
c3e706f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 2 of 2 to introduce self-contained Docker toolchain images with pre-populated Conan caches.
Here, we populate the Conan cache with packages for CE SDK and Houdini.