refactor: FieldSpecification context when targeting wrong fieldName

[arng40]

Here's the typical error encountered when setting the wrong target for a FieldSpecification :

***** LOCATION: /path/to/GEOS/src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp:208
***** Controlling expression (should be false): true
***** Rank 17:
initialPressure_channel/fieldName (staircase_3d.xml, l.133): there is no fieldName named `pressure_t` under the objectPath `ElementRegions/Channel`.
 
 
** StackTrace of 5 frames **
[...]
=====

Here we wanted to define initial conditions in FieldSpecifications to impose the value of a property (here: “rock_initialPorosity”).
However, this property doesn't exist because we've given it the wrong name. It expects the name of the Porosity model for stress (i.e. “rockPorosity_initialPorosity” here).

With more indications we would have (in progress)

***** LOCATION: /path/to/GEOS/src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp:228
***** Controlling expression (should be false): true
***** Rank 0: 
initialPressure_channel/fieldName (staircase_3d.xml, l.133): there is no fieldName named `pressure_t` under the objectPath `ElementRegions/Channel`.
Available fields in ElementRegions/Channel are:
bcPressure, bcTemperature, dMass, dMobility, deltaPressure, deltaVolume, gravityCoefficient, initialPressure, initialTemperature, mass, mass_n, mobility, netToGross, pressure, pressure_n, temperature, temperature_n

** StackTrace of 5 frames **
[...]

[MelReyCG]

This loop could completely be flatten.
Also, does the call to getRegisteringObjects() changes the result of the list?

[arng40]

loop can be flatten, afterwards this is a bit confusing 😅

[MelReyCG]

Nice!

[codecov]

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 56.64%. Comparing base (e09f499) to head (0eac053).

Files with missing lines	Patch %	Lines
...s/fieldSpecification/FieldSpecificationManager.cpp	5.26%	18 Missing ⚠️
src/coreComponents/mesh/ObjectManagerBase.hpp	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3508      +/-   ##
===========================================
- Coverage    56.65%   56.64%   -0.01%     
===========================================
  Files         1216     1216              
  Lines       105074   105091      +17     
===========================================
+ Hits         59529    59531       +2     
- Misses       45545    45560      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.