Execute code generation in cmake #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-H8/template-project into Code_generation_fix
…-H8/template-project into Code_generation_fix
g0nz4I0
requested changes
Mar 3, 2025
| @@ -4,8 +4,7 @@ | |||
| "path": "." | |||
| }, | |||
| { | |||
| "name": "ST-LIB", | |||
| "path": "../ST-LIB" | |||
| "path": "../Projectos/ST-LIB" | |||
jmaralo
requested changes
Mar 3, 2025
CMakeLists.txt
Outdated
| @@ -2,6 +2,7 @@ cmake_minimum_required (VERSION 3.14) | |||
|
|
|||
| project (template-project ASM C CXX) | |||
| set(EXECUTABLE ${PROJECT_NAME}.elf) | |||
| set(Board ${PROJECT_NAME}) | |||
There was a problem hiding this comment.
Suggested change
| set(Board ${PROJECT_NAME}) | |
| set(ADJ_BOARD ${PROJECT_NAME}) |
Comment on lines
+175
to
+178
| add_custom_target(run_generator ALL | ||
| COMMAND ${Python3_EXECUTABLE} ${GENERATOR_SCRIPT} ${Board} | ||
| WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} | ||
| ) |
There was a problem hiding this comment.
Core/Inc/Communications/JSON_ADE
Outdated
There was a problem hiding this comment.
move this submodule to Code_Generation
There was a problem hiding this comment.
I would remove this file, it is no longer needed
jmaralo
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Forget the previous review comment, but still the code is a bit hard to read, you should split all into four, one generator for data packets, another one for orders, another one for protections and another one for the state machine, and also split the generator, descriptors and templates into four. The code as is is a bit unclear and the option to just execute one generator is desirable
…/HyperloopUPV-H8/template-project into FW-301/Execute_Code_gen_on_cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you build the project it should detect the name of the board and creates the generated code of the board. Needs further testing but should work.
Oops now i see that i merged the other pr into this one, but well this pr only changes 4 lines in generator.py and the cmakelist