Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first version of new continuous_create_residuals #991

Merged
merged 21 commits into from
Mar 12, 2025
Merged

Conversation

jamesmkrieger
Copy link
Contributor

This is based on angular_continuous_assign2, but has 2 changes:

  1. There is no low-pass filter. We just have I and no Ifiltered
  2. We apply transformations to projection P and not to Ifiltered, so we get Pp instead of Ifilteredp

angular_continuous_assign2 already applies continuous A and B to the projection mP, not mIfilterp like I thought, so no change there, except for using mPp instead.

I can see with simulated data that the lack of low-pass filter definitely has a good effect in reducing positive log likelihoods.

@albertmena
Copy link
Collaborator

We have a set of test for the Xmipp programs: .
Could you create one for this continuous_create_residuals great program?, maybe you could base it on this other

@jamesmkrieger
Copy link
Contributor Author

We have a set of test for the Xmipp programs: . Could you create one for this continuous_create_residuals great program?, maybe you could base it on this other

Ok

@albertmena
Copy link
Collaborator

@jamesmkrieger we have to update to nolan de golds gold/xmipp_continuous_create_residuals_01/output.xmd
Can you share it with me?

@jamesmkrieger
Copy link
Contributor Author

@jamesmkrieger we have to update to nolan de golds gold/xmipp_continuous_create_residuals_01/output.xmd Can you share it with me?

How do I get the input files to do this?

@albertmena
Copy link
Collaborator

We need to upload the tmpLink/xmipp_continuous_create_residuals_01/output.xmd
to nolan/.../gold/xmipp_continuous_create_residuals_01 to allow the test to compare the output with gold.
To be sure about the file uploaded, please share it with me.

@jamesmkrieger
Copy link
Contributor Author

How do I get input/aFewProjections.sel and input/phantomBacteriorhodopsin.vol to generate output.xmd?

@jamesmkrieger
Copy link
Contributor Author

ok, I think I found them

@jamesmkrieger
Copy link
Contributor Author

I have sent you an email to your cnb address with the 3 files and also a query about the command failing to run in one directory.

@albertmena
Copy link
Collaborator

Are the test ready? can I upload the files:

  • xmipp_continuous_create_residuals_01/output.xmd
  • xmipp_continuous_create_residuals_02/output.xmd
  • xmipp_continuous_create_residuals_03/output.xmd
  • xmipp_continuous_create_residuals_04/output.xmd

@jamesmkrieger
Copy link
Contributor Author

I think everything is ready, yes. We still need to regenerate the test outputs with the revised program though.

@jamesmkrieger
Copy link
Contributor Author

I have added the test outputs to this pull request. I don't know if that is a good idea or will work but I guess you can take them from here

@albertmena
Copy link
Collaborator

albertmena commented Mar 11, 2025

I have added the test outputs to this pull request. I don't know if that is a good idea or will work but I guess you can take them from here

Is not necessary to upload the data test in the repository. I have uploaded it to nolan, the server where the test data is located.
Now all should works


def test_case3(self):
"Test output xmd and projections only"
self.runCase("-i input/aFewProjections.sel -o %o/output.xmd --ref input/phantomBacteriorhodopsin.vol--oprojections %o/projections.stk",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ref input/phantomBacteriorhodopsin.vol--oprojections
needs a blank space
--ref input/phantomBacteriorhodopsin.vol --oprojections

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
35.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@albertmena albertmena merged commit e2c0535 into devel Mar 12, 2025
6 of 7 checks passed
@albertmena albertmena deleted the jmk_new_residuals branch March 12, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants