Skip to content

feat: make elasticConfig.maxReplicas to a required parameter #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

feat: make elasticConfig.maxReplicas to a required parameter #331

merged 1 commit into from
Mar 26, 2025

Conversation

nayihz
Copy link
Contributor

@nayihz nayihz commented Mar 26, 2025

What this PR does / why we need it

/kind feature

Which issue(s) this PR fixes

Fixes ##326

Special notes for your reviewer

Does this PR introduce a user-facing change?

make elasticConfig.maxReplicas to a required parameter

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 26, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet March 26, 2025 08:39
@googs1025
Copy link
Contributor

/kind feature

@InftyAI-Agent InftyAI-Agent added feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 26, 2025
@kerthcet
Copy link
Member

/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2025
@InftyAI-Agent InftyAI-Agent merged commit fd77f80 into InftyAI:main Mar 26, 2025
43 of 44 checks passed
@nayihz nayihz deleted the hpa_max_replicas branch March 27, 2025 01:30
@nayihz nayihz mentioned this pull request Mar 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nayihz @googs1025 @kerthcet @InftyAI-Agent