tests: add integration tests to avoid false diffs in plugin protocols #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 28.91% 28.91%
=======================================
Files 62 62
Lines 6765 6765
=======================================
Hits 1956 1956
Misses 4667 4667
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harshadixit12
changed the title
|
Note: failing tests in CI should be fixed with https://github.com/Kong/deck/pull/1586/files |
harshadixit12
commented
Apr 7, 2025
go.mod
Outdated
| @@ -13,7 +13,7 @@ require ( | |||
| github.com/fatih/color v1.18.0 | |||
| github.com/google/go-cmp v0.7.0 | |||
| github.com/kong/go-apiops v0.1.41 | |||
| github.com/kong/go-database-reconciler v1.22.1 | |||
| github.com/kong/go-database-reconciler v1.22.2-0.20250403105251-3a1014c74cf4 | |||
There was a problem hiding this comment.
I'll bump the version once the failing tests are fixed on main and rebased here.
harshadixit12
force-pushed
the
fix/re-sync-ip-restriction-plugin-false-diff
branch
from
4002ad7 to
5854e71
Compare
Prashansa-K
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tests: add integration tests to verify no false diff when protocols are reordered in plugins
Fixes #1571
Depends on:
Kong/go-database-reconciler#240