Skip to content

feat: allow choosing install dir with NSIS #8456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat: allow choosing install dir with NSIS #8456

wants to merge 1 commit into from
+32 −10

Conversation

ryan-willis
Copy link
Contributor

todo:

  • check for updates in-app from github releases (if possible)
  • stop publishing Squirrel.Windows updates to API in CI
  • download, then quit + run NSIS installer

maybe:

  • see if there's a way for the nsis installer to detect that any version of Insomnia is running and ask that it be closed before proceeding

@ryan-willis ryan-willis force-pushed the feat/win-choose-install-dir branch from dd85d9d to 40a1d98 Compare March 15, 2025 02:44
@ryan-willis ryan-willis force-pushed the feat/win-choose-install-dir branch from 40a1d98 to 166c5b8 Compare April 14, 2025 18:05
@CurryYangxx
Copy link
Member

CurryYangxx commented Apr 24, 2025 •
edited
Loading

image

@ryan-willis seems it is already able to detect existing insomnia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-willis @CurryYangxx