Skip to content

Refactor/Add testsuite release workflow #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

averevki
Copy link
Contributor

@averevki averevki commented Apr 8, 2025

Description

  • Refactor github CI to push to static AND floating testsuite images every merge. Floating tags are based on last commit SHA
  • Add testsuite release workflow that can be triggered by pushing tag named in SymVer convention (vX.Y.Z) or directly in github(tag will be pushed by workflow in that case). The release workflow will push new version github tag, push :latest and :${version} images to the quay, and create new testsuite github release.

Closes #79 Closes #242

Verification steps

Eye review

--OR--

Merge this change to your testsuite fork, add IMG_REGISTRY_USERNAME(quay.io username) and IMG_REGISTRY_TOKEN(quay.io password) to your fork project actions secrets(to be able to push to quay/testsuite). Activate release workflow on github actions page. Push the version tag to activate release workflow.

Signed-off-by: averevki <sandyverevkin@gmail.com>
@averevki averevki requested review from trepel and Copilot April 8, 2025 23:21
@averevki averevki self-assigned this Apr 8, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • .github/workflows/build_release_image.yml: Language not supported
  • .github/workflows/promote_to_latest.yml: Language not supported
Comments suppressed due to low confidence (3)

.github/workflows/release.yml:20

  • [nitpick] Consider quoting the IMG_TAGS value to ensure proper YAML parsing and to avoid any unintended splitting of the tag string.
IMG_TAGS: latest ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.version_tag || github.ref_name }}

.github/workflows/build_unstable_image.yml:12

  • [nitpick] Verify that combining 'unstable' with the commit SHA as a space-separated string produces the intended tag format, and consider quoting or reformatting if necessary to match the expected input for the build action.
IMG_TAGS: unstable ${{ github.sha }}

.github/workflows/acceptance.yml:1

  • [nitpick] Ensure that the new workflow name 'Code static analysis' accurately reflects the workflow's purpose if it still encompasses broader acceptance tests.
name: Code static analysis

Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I managed to make this work using my own fork. Great work!

@trepel trepel merged commit cecab92 into Kuadrant:main Apr 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image builds: use static tags in addition to floating ones Figure out test suite release process
2 participants