Removed new lines in the sql query to sdss which was crashing intermittently #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccully
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a strange crash in comparecatalogs.py. This was crashing in the SQL query to sdss. When I checked the response from the SDSS server it said "Uncaught error occurred" without more information. The bug was intermittent. If I used the exact parameters from AT 2024zkl, it would crash. If I changed the radius from 20.0 to 20 or 15.0 everything worked. Removing the newlines in the SQL query seemed to fix it in as much that it ran for 24zkl. Beyond that I haven't been able to reproduce the bug so its hard to validate it more than that.