refactored grammers-tl-gen to generate each of the types, functions and enums to a separate file
#311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lonami
reviewed
Feb 11, 2025
…ums to a seperate file
|
all done, also I rebased my changes so the history is clean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR will modify the tl-gen so it generate each of types, functions and enums to a separate file, the reason I did this is, if we have all of them in a single file the resulted generated file will be so big and that will cause some problems with RA.
I did found some strange problems while doing these changes, like if we add doc comments (
//!) to start of the generated rust source and then include that file in another file, the rust compiler will give us a error and complain that we can't use these comments here... that's why I no longer add the license and top doc comment directly to the source file when generating, instead I manually added them to the actual module that generated sources will be included in.I also fixed the small bug after the recent
Usertype changes.