Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stashed Experimental Package: iFrame Functionality #173

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

claykohut-mysten
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


@claykohut-mysten claykohut-mysten requested a review from a team as a code owner April 3, 2025 15:41
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 3:37pm

@claykohut-mysten claykohut-mysten changed the base branch from main to ck/stashed-package-experimental April 3, 2025 15:41
@claykohut-mysten claykohut-mysten temporarily deployed to sui-typescript-aws-kms-test-env April 3, 2025 15:42 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Apr 3, 2025

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@claykohut-mysten claykohut-mysten temporarily deployed to sui-typescript-aws-kms-test-env April 3, 2025 16:19 — with GitHub Actions Inactive
export type IframeMessageType = 'WALLET_STATUS' | 'IFRAME_READY';

export const IframeMessageWalletStatusPayload = object({
type: union([literal('WALLET_STATUS'), literal('IFRAME_READY')]),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to be able to do literal('WALLET_STATUS', 'IFRAME_READY') but TS was complaining about it.

@claykohut-mysten claykohut-mysten temporarily deployed to sui-typescript-aws-kms-test-env April 3, 2025 18:36 — with GitHub Actions Inactive
@claykohut-mysten claykohut-mysten temporarily deployed to sui-typescript-aws-kms-test-env April 4, 2025 15:32 — with GitHub Actions Inactive
@claykohut-mysten claykohut-mysten temporarily deployed to sui-typescript-aws-kms-test-env April 4, 2025 15:33 — with GitHub Actions Inactive
@claykohut-mysten claykohut-mysten changed the title [wip] Stashed Experimental Package: iFrame (not ready for review) Stashed Experimental Package: iFrame Functionality Apr 4, 2025
@claykohut-mysten claykohut-mysten force-pushed the ck/stashed-package-experimental branch from de5a15e to d31fae1 Compare April 4, 2025 21:24
Base automatically changed from ck/stashed-package-experimental to main April 4, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant