Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check current instance status before update. #1569

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

OlgaMaciaszek
Copy link
Contributor

This is related to spring-cloud/spring-cloud-netflix#4094 as an attempted fix.

@OlgaMaciaszek OlgaMaciaszek marked this pull request as ready for review February 4, 2025 16:19
@OlgaMaciaszek
Copy link
Contributor Author

@howardyuan could you please take a look?

@OlgaMaciaszek
Copy link
Contributor Author

Adding pic with comments from offline discussion:
Screenshot 2025-03-04 at 9 02 17 AM

@OlgaMaciaszek
Copy link
Contributor Author

Hi @howardyuan, regarding your comments before, I still use the pre-existing method under the hood from here, so setIsDirty will be called as well if we do change the status. I have added an exception when we verify the previous status first, as in this scenario we assume that it is the status that should be there in a correct workflow and if it's not set then possibly there was a race condition. null is returned in the pre-existing implementation if the status we want to change to is also the one already set - so nothing needs to be done. Seems like a different scenario to me. Let me know what you think. CC @spencergibb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant