Skip to content

Add customization for Template structure #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

LostAquilae
Copy link
Contributor

Add functions to customize the Template structure, allowing users to modify prefix, suffix, separator and the number of bytes per line.

Also proposes a new default prefix for Rust template.

Copy link
Owner

@Nicoretti Nicoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please let me know if and when you need the changes to be released. If I find some time over the weekend, I will look into partially automating the releasing process.

Note: Please consider bumping the version number as part of a PR/change, especially if a release is required afterward.

@LostAquilae
Copy link
Contributor Author

LostAquilae commented Mar 25, 2025

Thank you for your feedback !

Yes, a release would be desirable. Take your time to do it though, no rush.

About bumping the version, this is only in the Cargo.toml right ? Release on github and crates.io will be done automatically ? Let me know if you need me to do anything.

I also noticed some jobs in CI were failing, do we need to fix that ?

@Nicoretti
Copy link
Owner

Yes, a release would be desirable. Take your time to do it though, no rush.

I'll try to get to it at the weekend, if not feel free to ping me next week.

About bumping the version, this is only in the Cargo.toml right ? Release on github and crates.io will be done automatically ? Let me know if you need me to do anything.

Yes it only needs to be changed in the Cargo.toml.

I also noticed some jobs in CI were failing, do we need to fix that ?

I likely will remove the failing builds, they created binaries for different platforms for download on GitHub.
If you wold like to keep them feel free to fix them ;).

@Nicoretti
Copy link
Owner

@LostAquilae could you please make your PR/PR-Branch editable?

@LostAquilae
Copy link
Contributor Author

Sorry for the late reply. I bumped the version number inside the Cargo.toml.

Also, I think my branch should be editable by maintainers of your repo, as I have the checkbox "Allow edits by maintainers" checked. It said that user with write access to this repo should be able to push new commits to the master branch on my fork, as I used the master branch to create this PR (which is not a good practice, sorry about that).

Can you check if it's possible for you to edit the master branch on my fork ?

Thank you

@Nicoretti Nicoretti merged commit 8b1b387 into Nicoretti:master Apr 1, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants