-
Notifications
You must be signed in to change notification settings - Fork 5
Add customization for Template structure #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, separator and number of bytes per line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please let me know if and when you need the changes to be released. If I find some time over the weekend, I will look into partially automating the releasing process.
Note: Please consider bumping the version number as part of a PR/change, especially if a release is required afterward.
Thank you for your feedback ! Yes, a release would be desirable. Take your time to do it though, no rush. About bumping the version, this is only in the Cargo.toml right ? Release on github and crates.io will be done automatically ? Let me know if you need me to do anything. I also noticed some jobs in CI were failing, do we need to fix that ? |
I'll try to get to it at the weekend, if not feel free to ping me next week.
Yes it only needs to be changed in the
I likely will remove the failing builds, they created binaries for different platforms for download on GitHub. |
@LostAquilae could you please make your PR/PR-Branch editable? |
Sorry for the late reply. I bumped the version number inside the Cargo.toml. Also, I think my branch should be editable by maintainers of your repo, as I have the checkbox "Allow edits by maintainers" checked. It said that user with write access to this repo should be able to push new commits to the master branch on my fork, as I used the master branch to create this PR (which is not a good practice, sorry about that). Can you check if it's possible for you to edit the master branch on my fork ? Thank you |
Add functions to customize the Template structure, allowing users to modify prefix, suffix, separator and the number of bytes per line.
Also proposes a new default prefix for Rust template.