-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nixos manual #391626
base: master
Are you sure you want to change the base?
Fix nixos manual #391626
Conversation
hello @fricklerhandwerk please could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello!
Congratulations for your first PR !
I added a minor comment, also, make sure to format the PR title according to the user contributor guide, the commit messages should also be reworked accordingly.
|
||
```ShellSession | ||
$ cd /path/to/nixpkgs/nixos/doc/manual | ||
$ nix-shell | ||
nix-shell$ devmode | ||
[nix-shell:~]$ devmode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fricklerhandwerk said the shell prompt that doesn’t look like the actual thing and we don't use the 'make' command anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @drupol 👋🏻
Please could you leave a link to the user contributor guide? There are so many documentations and I am finding it hard to locate the user contributor guide.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to update the commit log messages and the PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah working on it
Thank you so much 👍🏻
Fixed inconsistencies in NixOS Manual
Fixed outdated references to
make
, corrected shell prompts fromnix-shell$
to[nix-shell:~]$
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.