-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator; enable sequential conduit updates #556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example where two conduits belong to the same update group
|
a26e23d
to
2349c9b
Compare
2349c9b
to
51dfb7c
Compare
Users can group Conduits into update groups by annotating Conduit Custom Resources with the update-sync-group key. Within an update group, Conduit updates are executed sequentially rather than in parallel. The annotation value of a Conduit Custom Resource can be added/changed/removed on the fly. The default annotation key can be changed via the operator environment variable CONDUIT_UPDATE_SYNC_GROUP_KEY when deploying the operator. Locking is achieved using in-memory locks, which are fast and provide a sufficiently good solution. However, this approach is not effective in case of operator crashes during ongoing updates. Such crashes would be considered a bug to be fixed and should not occur in general.
51dfb7c
to
4dcf01b
Compare
b3b5f89
to
133a8c3
Compare
133a8c3
to
dc32080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/configuration
component/operator
concept/conduit
kind/documentation
Improvements or additions to documentation
kind/enhancement
New feature or request
priority/medium
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users can group Conduits into update groups by annotating Conduit Custom Resources with the
update-sync-group
key. Within an update group, Conduit updates are executed sequentially rather than in parallel.The default annotation key can be changed via the operator environment variable
CONDUIT_UPDATE_SYNC_GROUP_KEY
when deploying the operator.Locking is achieved using in-memory locks, which are fast and provide a sufficiently good solution. However, this approach is not effective in case of operator crashes during ongoing updates. Such crashes would be considered a bug to be fixed and should not occur in general.
The feature has support for changing the annotation value of a Conduit Custom Resource on the fly. (Including removing it completely.)
However, no immediate control can be expected when changing the update group of a Conduit whose Proxy's Status subresource still indicates underlying changes (e.g. in POD readiness) while the DaemonSet otherwise reflects the desired state. This is because the logic relies on the Status subresource to accurately track the progress of updates and ensure consistency.
Also, existing Conduit Custom Resources can be annotated before upgrading to a Meridio version that supports serialized Conduit updates. In this case, the new operator will respect the update groups of the "old" Conduits from the start.
Note: There is no benefit to having a single Conduit in an update group.
Issue link
#555
Checklist