[18.0] [MIG] delivery_postlogistics: Migration to 18.0

[StephaneMangin]

Includes:

• reusing of "delivery.carrier.template.option" from OCA module "delivery_carrier_option"
• reusing of "shipping.label" from OCA module "delivery_carrier_shipping_label" instead of custom "postlogistics.shipping.label"
• Add a default package type to fullfill postlogistics_send_shipping requirements (Using ECO default shipping pricing)

Depends on:

• [18][ADD/MIG] delivery_carrier_option (extracted from base_delivery_carrier_label module) #900
• [18.0][MIG] delivery_carrier_info: Migration to 18.0 #936
• [18][ADD] delivery_carrier_shipping_label : extracted from base_delivery_carrier_label #938

Due to some modules overrding the web service and as this implementation doesn't allow to properly chain modules (that could not be chained). An API refactoring has occur to allow to override from the picking instead of the webservice (some prepare methods)

[StephaneMangin]

Superseeds #940

[yankinmax]

hello @StephaneMangin
There is an issue in migration. You're overriding the selection of the type field declared for delivery.carrier.template.option model in delivery_carrier_option module.
Here is Odoo logs:

WARNING testdb odoo.fields: delivery.carrier.template.option.type: selection=[('label_layout', 'Label Layout'), ('output_format', 'Output Format'), ('resolution', 'Output Resolution'), ('basic', 'Basic Service'), ('additional', 'Additional Service'), ('delivery', 'Delivery Instructions'), ('partner_option', 'Partner Option')] overrides existing selection; use selection_add instead

[rousseldenis]

/ocabot migration delivery_postlogistics

[StephaneMangin]

hello @StephaneMangin There is an issue in migration. You're overriding the selection of the type field declared for delivery.carrier.template.option model in delivery_carrier_option module. Here is Odoo logs:

WARNING testdb odoo.fields: delivery.carrier.template.option.type: selection=[('label_layout', 'Label Layout'), ('output_format', 'Output Format'), ('resolution', 'Output Resolution'), ('basic', 'Basic Service'), ('additional', 'Additional Service'), ('delivery', 'Delivery Instructions'), ('partner_option', 'Partner Option')] overrides existing selection; use selection_add instead

Yes it is transitional, because these values are added in a dependency. Updating...

[leemannd]

I suspect this will not work.

1. The model is already created by the module delivery_carrier_option

2025-03-25 16:20:21,900 98 ERROR prod odoo.sql_db: bad query: b"UPDATE ir_model SET model = 'delivery.carrier.template.option' WHERE model = 'postlogistics.delivery.carrier.template.option'"
ERROR: duplicate key value violates unique constraint "ir_model_obj_name_uniq"
DETAIL:  Key (model)=(delivery.carrier.template.option) already exists.
 
2025-03-25 16:20:21,901 98 ERROR prod OpenUpgrade: Error after 0:00:00.001743 running UPDATE ir_model SET model = 'delivery.carrier.template.option' WHERE model = 'postlogistics.delivery.carrier.template.option' 
2025-03-25 16:20:21,977 98 WARNING prod odoo.modules.loading: Transient module states were reset 
2025-03-25 16:20:21,980 98 ERROR prod odoo.modules.registry: Failed to load registry 
2025-03-25 16:20:21,980 98 CRITICAL prod odoo.service.server: Failed to initialize database `prod`. 
Traceback (most recent call last):
  File "/odoo/src/odoo/service/server.py", line 1318, in preload_registries
    registry = Registry.new(dbname, update_module=update_module)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/decorator.py", line 232, in fun
    return caller(func, *(extras + args), **kw)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/odoo/src/odoo/tools/func.py", line 97, in locked
    return func(inst, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/odoo/src/odoo/modules/registry.py", line 127, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/odoo/src/odoo/modules/loading.py", line 476, in load_modules
    processed_modules += load_marked_modules(env, graph,
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/odoo/src/odoo/modules/loading.py", line 364, in load_marked_modules
    loaded, processed = load_module_graph(
                        ^^^^^^^^^^^^^^^^^^
  File "/odoo/src/odoo/modules/loading.py", line 181, in load_module_graph
    migrations.migrate_module(package, 'pre')
  File "/odoo/src/odoo/modules/migration.py", line 254, in migrate_module
    mod.migrate(self.cr, installed_version)
  File "/odoo/external-src/delivery-carrier/delivery_postlogistics/migrations/18.0.1.0.0/pre-migration.py", line 61, in migrate
    _rename_models(cr)
  File "/odoo/external-src/delivery-carrier/delivery_postlogistics/migrations/18.0.1.0.0/pre-migration.py", line 40, in _rename_models
    openupgrade.rename_models(cr, models_spec)
  File "/usr/local/lib/python3.12/site-packages/openupgradelib/openupgrade.py", line 922, in rename_models
    logged_query(
  File "/usr/local/lib/python3.12/site-packages/openupgradelib/openupgrade.py", line 1730, in logged_query
    cr.execute(query, args)
  File "/odoo/src/odoo/sql_db.py", line 354, in execute
    res = self._obj.execute(query, params)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "ir_model_obj_name_uniq"
DETAIL:  Key (model)=(delivery.carrier.template.option) already exists.

AFAIR best is:

• migrate the records from previous model to the new one
• use merge_models -> https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade.py#L1135 (I never used it)