[17.0][ADD] add hr_governance module #1455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luca-Policastro
force-pushed
the
C2C-2439
branch
5 times, most recently
from
6537631 to
a52ba41
Compare
| def _is_assigned_w_steering(self): | ||
| self.ensure_one() | ||
| steering_role = self.env.ref( | ||
| "hr_governance.steering_gct", raise_if_not_found=False |
There was a problem hiding this comment.
IMO we shouldn't have business code depend on configurable records like the role types.
Instead, we should perhaps have a "type"-like selection field on the role types, with predefined values like "steering", and use it instead.
That way the code wouldn't rely on given records being created (through xmlid), an rely instead on record configurations
not blocking, though. can be a future improvement
hr_governance/static/src/components/circlepack_colorlist.esm.js
Outdated
Show resolved
Hide resolved
rvalyi
changed the title
Luca-Policastro
force-pushed
the
C2C-2439
branch
from
a52ba41 to
5296eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.