Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] hr_timesheet_begin_end: Migration to 18.0 #729

Merged
merged 11 commits into from
Apr 10, 2025

Conversation

BhaveshHeliconia
Copy link

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Jan 2, 2025
7 tasks
Copy link

@JessBrandl JessBrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, Tested in runboat and works as intended
Additionally commit history can be squashed
image

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-hr_timesheet_begin_end branch from 89bb628 to ef3fde7 Compare January 17, 2025 06:48
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-hr_timesheet_begin_end branch from ef3fde7 to cd404e0 Compare February 7, 2025 10:21
CRogos and others added 11 commits March 31, 2025 16:20
[UPD] Update hr_timesheet_begin_end.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_begin_end/

[UPD] README.rst
Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (6 of 6 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_begin_end/pt_BR/
Translated using Weblate (Catalan)

Currently translated at 100.0% (6 of 6 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_begin_end/ca/
Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. As Jessy mentioned, the two commits can be squashed

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BhaveshHeliconia
Copy link
Author

Hey @OCA/project-service-maintainers when you get a chance, kindly review and consider merging it.

@AEstLo
Copy link

AEstLo commented Apr 10, 2025

@pedrobaeza can this be merged?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration hr_timesheet_begin_end
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 10, 2025
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-729-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6fd478a into OCA:18.0 Apr 10, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3d29f3f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants