[IMP] hr_employee_cost_history: add comment field in history line #735
Conversation
|
This PR has the |
|
/ocabot merge minor @EmilioPascual @Shide FYI |
|
On my way to merge this fine PR! |
|
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-735-by-rafaelbn-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@glitchov ! 😄 thanks! Please review, test fails 🔴 ! ❤️ |
|
@rafaelbn Hi Rafael, i had a look but i can't reproduce and it has nothing to do with my changes sorry. |
glitchov
force-pushed
the
16.0-imp-hr_employee_cost_history_add_comment_field-hda
branch
from
cd27944 to
8fe32ab
Compare
|
The error is in |
|
/ocabot merge minor |
|
Sorry @rafaelbn you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
sbidoul
force-pushed
the
16.0-imp-hr_employee_cost_history_add_comment_field-hda
branch
from
b88ba1e to
8fe32ab
Compare
|
@rafaelbn the branch is green again. Can you retry the merge? |
This PR adds a comment field on the history line to tell why the cost change did happen.
closes #696
A very small fix has been added for hr_timesheet_name_customer because Odoo has added a new test in sale_timesheet (test_billing_project/test_take_into_account_invoicing_app_legacy) which failed without doing a secure get in vals dict.