-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .venv/ to gitignore #1335
base: devel
Are you sure you want to change the base?
Add .venv/ to gitignore #1335
Conversation
Reviewer's Guide by SourceryThis pull request adds the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @theodore-s-beers - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding
__pycache__/
to the .gitignore as well.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
PR Description
In the case of our deployments, at least—using the Docker Compose workflow for the repo service—part of the process is setting up a Python virtual environment, so that the Globus SDK can be installed. I noticed that the virtual environment folder, conventionally
.venv
, is not gitignored. This PR is simply to add that line to the ignorefile.Tasks
Summary by Sourcery
Chores: