Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joshua s brown http communicator 2 #989

Open
wants to merge 11 commits into
base: devel
Choose a base branch
from

Conversation

JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Aug 10, 2024

Description

This pr is the first steps in a code refactor. The point of the refactor is to remove redundant HTTPS communication implementations throughout the code and standardize the HTTPS requests and responses with the interface currently used by ZeroMQ. This PR does not address HTTPS, it addresses HTTP communication traffic and has set up the foundation for adding HTTPS support. The HTTP communication is implemented in a standardized way using the "common" library which is used throughout datafed.

  • Added Classes:
    -HTTP Communicator
    -HTTP Credentials
    -HTTP Socket
    -StringMessage
    -CredentialsTest

  • Changes:
    -CMakeLists within common folder (Implemented Curl and SSL libraries)
    -IMessage header (Implemented Endpoint, Verb, Body to Message Attributes)
    -Util classes (Implemented functions for parsing messages for HTTP Communications)
    -CommunicatorFactory classes (Handles creation of HTTPCommunicator)
    -CredentialFactory classes (Handles creation of HTTPCredentials)
    -MessageFactory classes (Handles creation of StringMessage)
    -SocketFactory classes (Handles creation of HTTPSocket)
    -CMakeLists in unit tests (Starts/Stops flask server for http testing)

  • My tests within CommunicatorFactory:
    -Factory Creation
    -Message send/recieve

  • My tests within MessageFactory:
    -StringMessage Creation
    -MsgFactory Creation

  • My tests within CredentialsFactory:
    -HTTPCredentials Creation

  • What is needed for future development:
    -Implement HTTPS and Replace uses of curl commands within the application with centralized method.

  • Why it's needed:
    -Building blocks for HTTPS
    -Centralizing communications between Globus and Datafed

@JoshuaSBrown JoshuaSBrown mentioned this pull request Aug 10, 2024
@JoshuaSBrown
Copy link
Collaborator Author

@par-hermes format

@JoshuaSBrown JoshuaSBrown added Component: Core Relates to core service Component: Repository Relates to repository service Type: Refactor Imlplementation change, same functionality labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Relates to core service Component: Repository Relates to repository service Type: Refactor Imlplementation change, same functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants