-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joshua s brown http communicator 2 #989
Open
JoshuaSBrown
wants to merge
11
commits into
devel
Choose a base branch
from
JoshuaSBrown_HTTP_Communicator_2
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… everything with implemented changes.
… to accomodate the correct form
Closed
@par-hermes format |
…taFed into JoshuaSBrown_HTTP_Communicator_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Core
Relates to core service
Component: Repository
Relates to repository service
Type: Refactor
Imlplementation change, same functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is the first steps in a code refactor. The point of the refactor is to remove redundant HTTPS communication implementations throughout the code and standardize the HTTPS requests and responses with the interface currently used by ZeroMQ. This PR does not address HTTPS, it addresses HTTP communication traffic and has set up the foundation for adding HTTPS support. The HTTP communication is implemented in a standardized way using the "common" library which is used throughout datafed.
Added Classes:
-HTTP Communicator
-HTTP Credentials
-HTTP Socket
-StringMessage
-CredentialsTest
Changes:
-CMakeLists within common folder (Implemented Curl and SSL libraries)
-IMessage header (Implemented Endpoint, Verb, Body to Message Attributes)
-Util classes (Implemented functions for parsing messages for HTTP Communications)
-CommunicatorFactory classes (Handles creation of HTTPCommunicator)
-CredentialFactory classes (Handles creation of HTTPCredentials)
-MessageFactory classes (Handles creation of StringMessage)
-SocketFactory classes (Handles creation of HTTPSocket)
-CMakeLists in unit tests (Starts/Stops flask server for http testing)
My tests within CommunicatorFactory:
-Factory Creation
-Message send/recieve
My tests within MessageFactory:
-StringMessage Creation
-MsgFactory Creation
My tests within CredentialsFactory:
-HTTPCredentials Creation
What is needed for future development:
-Implement HTTPS and Replace uses of curl commands within the application with centralized method.
Why it's needed:
-Building blocks for HTTPS
-Centralizing communications between Globus and Datafed