Move functions from notebooks to fusets packages #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
commented
Apr 14, 2022
src/fusets/mogrp.py
Outdated
| if i_test == 0: | ||
|
|
||
| for ind in range(noutput_timeseries): | ||
| out_mean[ind][:, None, x, y] = (Yp[:, None, 0] * Y_std_vec[ind] + Y_mean_vec[ind]) / Nt |
There was a problem hiding this comment.
@msalinero (FYI: I copied this from AI4FOOD_OpenEO_MOGPR_S1S2.ipynb )
this line (and 3 other lines) use a variable Nt that is not defined anywhere.
There was a problem hiding this comment.
as discussed with @msalinero L Nt should be nt here
| import numpy as np | ||
|
|
||
|
|
||
| def create_empty_2D_list(nrows, ncols): |
There was a problem hiding this comment.
@msalinero : is it necessary to define this function? can't we just use np.zeros((nrows, ncols)) or a python oneliner like [[0] * ncols for _ in range(nrows)] ?
There was a problem hiding this comment.
@soxofaan So sorry for the very very late response. Indeed it is not necessary. [[0] * ncols for _ in range(nrows)] is tested and works fine.
Closed
soxofaan
force-pushed
the
issue46-src-tree
branch
from
87145a2 to
2836e67
Compare
soxofaan
added a commit
that referenced
this pull request
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #46 : move functions from notebooks to real
fusetspackages/modules