Reflection move sampler #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflection relative to a given plane in labolatory reference frame. It is realized by rotation and reflects particle primary axis
PKua007
requested changes
Feb 9, 2025
|
|
||
| void setStepSize(const std::string &, double) override { } | ||
|
|
||
| void setupForShapeTraits(const ShapeTraits &shapeTraits) override { |
There was a problem hiding this comment.
You can save only the primary axis instead of storing the pointer to ShapeGeometry.
There was a problem hiding this comment.
primary axis should be recalculated each time due to particle rotation, thus there is no advantage of storing it in terms of calculation time. On the other hand, storing a pinter takes less memory than storing a vector
There was a problem hiding this comment.
We don't have to worry about the memory footprint of a single instance of the class. The problem is that ShapeGeometry::getPrimaryAxis is a virtual function called repeatedly in a critical code path, which prevents many optimization that compiler can do.
reflection relative to a given plane in labolatory reference frame. It is realized by rotation and reflects particle primary axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.