refactor: replace List with Set for filter values in JsonPath evaluat… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion, including other optimizations of loops over streams
Tushar-Naik
commented
Apr 23, 2025
| @@ -199,17 +211,29 @@ public Boolean visit(GenericFilter filter) { | |||
|
|
|||
|
|
|||
| private <T> Boolean applyAllMatchFilter(Filter filter, TypeRef<List<T>> typeRef, Predicate<T> predicate) { | |||
| List<T> nonNullValues = nonNullValues(filter, typeRef); | |||
| return isNotEmpty(nonNullValues) && nonNullValues.stream().allMatch(predicate); | |||
| List<T> values = readContextValues(filter, typeRef); | |||
There was a problem hiding this comment.
Benchmark Mode Cnt Score Error Units
JsonPathEvalBenchmark.newerImpl thrpt 5 4319391.869 ± 107293.083 ops/s
JsonPathEvalBenchmark.olderImpl thrpt 5 3545470.314 ± 133759.198 ops/sThere was a problem hiding this comment.
This benchmark only includes this function, and excludes the List->Set conversion from query-dsl. That would be added improvement
|
zodvik
reviewed
Apr 24, 2025
| } | ||
|
|
||
| private Boolean valueInValueSet(List<Object> values, Set<Object> valueSet) { | ||
| if (!isNotEmpty(values)) { |
There was a problem hiding this comment.
nit for later - remove double negative
| List<T> values = context.documentContext().read(filter.getField(), typeRef); | ||
| if (log.isTraceEnabled()) { | ||
| log.trace(BONSAI_FILTER_VALUES_DOCUMENT_LOG_STR, context.id(), filter.getField(), values, | ||
| context.documentContext().json()); | ||
| } | ||
| return values == null ? Collections.emptyList() : values.stream().filter(Objects::nonNull).toList(); | ||
| return values == null ? Collections.emptyList() : values; |
There was a problem hiding this comment.
Why not filter for non null here? This then needs all callers to check for null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion, including other optimizations of loops over streams