Removed Completed event from AsyncEffectRenderer
#1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronwhite
reviewed
Apr 3, 2025
| // Create live preview surface. | ||
| // Start rendering. | ||
| // Listen for changes to effectConfiguration object, and restart render if needed. | ||
| // Handle selection path. |
There was a problem hiding this comment.
I think this comment went along with the code (now further down) for initializing the render bounds from the selection. It's not a particularly useful comment though
There was a problem hiding this comment.
Yeah, that's fair that we want to leave it until after Pinta 3.0.
Also, thanks @cameronwhite for noticing. I removed the comment (which the commit message says is "irrelevant" but should've been "unnecessary").
…_completion_event
…_completion_event
…_completion_event
…_completion_event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback mess was untangled and the code is now sequential and easier to follow.
Next, we might want to address the
Updateevent and then actually create aRenderHandleclass, as discussed in #1009 (comment), but that's a topic for a future pull request. I already tinkered with it, and it is less straightforward than it appears to be due toEffectData_PropertyChanged, which I think has to be moved out ofLivePreviewManager, and itsStartmethod needs to be able to be canceled externally through aCancellationTokenpassed as an argument.