Add k_kteam_messages #396
Open
Add k_kteam_messages #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting k_kteam_messages, the following messages will appear in white instead of the red text and green numbers: - The match has begun! - [x] minutes remaining - [x] seconds
|
Why? Smells a bit like overcustomization? Better to build consensus with either option. |
|
I watched an old demo from around 1999 and noticed that the strings I changed in this PR were in plain white. I thought it looked nice, so I wanted to have the option to use it today as well. It's not a big deal—feel free to close it if you prefer. |
|
I would say to me this is a must have addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting k_kteam_messages, the following messages will appear in white instead of the red text and green numbers: