Refactor and add StridedView support
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkdvos
requested changes
Nov 2, 2024
There was a problem hiding this comment.
In general, looks good to me!
I think there are quite a few tests that are not really using the backend, or might not make a lot of sense to test here, I think it is fine to assume that if the interface functions work, and a few tensor contractions too, everything should be fine.
One additional note is that for the tensor contractions, we might want to have some (more) tests with Bumper and the manual allocator, just to make sure that these are also supported.
|
Ok, I think I covered all of your comments. I just changed everything locally and pushed the changes, which was easier than committing some of the changes you made and merging them with the ones I already had locally. |
lkdvos
force-pushed
the
jh/completeoverhaul
branch
2 times, most recently
from
ef42e11 to
f63a457
Compare
lkdvos
approved these changes
Nov 3, 2024
lkdvos
force-pushed
the
jh/completeoverhaul
branch
from
f63a457 to
efc9fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete overhaul to mimick the strided implementation from TensorOperations.jl. Also more tests.
It seems TBLIS does support a beta argument by encoding it in the C tensor structure, before entering the add or mult method. It also supports the conjugation flag in the add method (also used for trace), but unfortunately not in the mult (tensor contraction) method. We work around this by allocating a temporary for the conjugated tensor.
I think this is ready for review.