Add pagination support to bookmark context #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented infinite scrolling with IntersectionObserver for better performance - Added pagination API endpoint support in the frontend - Updated BookmarkContext to support loading bookmarks in chunks as user scrolls - Created tests for the pagination functionality - Fixed compatibility with existing code and handling of tags/filtering 🤖 Generated with Claude Code Co-Authored-By: shayesdevel@gmail.com
|
Please fix the following behaviors:
|
R-Sandor
requested changes
Mar 5, 2025
| @@ -69,6 +69,12 @@ const api = { | |||
| getAllBookmarks() { | |||
| return this.execute("GET", "bookmarks", null, {}); | |||
| }, | |||
| // Get paginated bookmarks. | |||
| getPaginatedBookmarks(page: number, size: number = 10) { | |||
| if (typeof IntersectionObserver !== 'undefined') { | ||
| const observer = new IntersectionObserver(handleObserver, { | ||
| root: null, | ||
| rootMargin: '20px', |
There was a problem hiding this comment.
Maybe make this a little bit bigger because its not getting the next page until I am well scrolled down and it lags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Co-Authored-By: shayesdevel@gmail.com
Issue number: resolves #
Checklist
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information