Add automatic DLL support for Windows Ruby Installer #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
commented
Feb 25, 2025
| @@ -5,7 +5,7 @@ module RbNaCl | |||
| # Defines the libsodium init function | |||
| module Init | |||
| extend FFI::Library | |||
| ffi_lib ["sodium", "libsodium.so.18", "libsodium.so.23", "libsodium.so.26"] | |||
| ffi_lib ["sodium", "libsodium.so.18", "libsodium.so.23", "libsodium.so.26", "libsodium-26"] | |||
There was a problem hiding this comment.
It would be nice to reduce this duplication with RbNacl::Sodium class. Any suggestion on how to do it--define a shared constant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the Gemspec
msys2_mingw_dependenciesmetadata to automatically install the appropriate Mingw package. You can see the same thing is used for the Psych gem here.This saves Windows users the trouble of downloading/renaming the DLL file.
You can see here the file is located at
/ucrt64/bin/libsodium-26.dllon the Mingw package, hence we need to add a new possible package name to theffi_libcall.