-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primitive formspec testing feature #92
base: master
Are you sure you want to change the base?
Conversation
I've done some work with formspec testing, unfortunately I've messed up local dev and have not pushed anything here in long time. Trying to get it sorted out... some day. I'll try to merge this PR with what I've done so far (formspec parsing, looking for elements, player formspec, etc.). |
Oops, looks like I have forgotten this PR. Admittedly it was too ambitious for my skills at the time so it ran out of steam quite quickly. |
Did some rebasing in an attempt to mix in your work and to get somewhat clean history out of it, preview here: Howevert, your last commit Add primitive wrapper for quitting formspecs isn't there, others are in one form or another. Things I should probably drop before making a release:
|
This should at least partially address #53.
This PR is still WIP. Specifically, it does not provide an API to "interact" (*) with formspec elements, and formspecs need to be parsed in order to send the fields correctly.
(*) Whether the specific element is present is a different matter. IMO not checking this allows mods to test whether the callback handles certain situations correctly, e.g. formspecs where some parts are conditionally hidden but have only one callback function (which also need to have the code to make sure certain fields are not handled when they are not supposed to be).