feat(env): prevent duplicated PATH from fnm env #1408
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* `fnm env` will look for `fnm_multishells` on the environment variable `$PATH`.
* If found it will not print the `PATH` variable, thus preventing it to be duplicated.
* It also uses the value for set `FNM_MULTISHELL_PATH` but stripes out the `/bin`
fabricionaweb
force-pushed
the
feat/avoid-duplicate-env
branch
from
ac9ce4a to
ae2e792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previous discussed on #1309 (and maybe somewhere else), the current behavior is to always make a new symlink and append this new folder to PATH.
While I understand this works fine and one usually does not call
fnm envmultiple times for a shell session, I believe this has room to improve...I made this change to be less aggressive. I didn't touch other variables and just attacking these two variables that are mutable and related.
On this PR I propose:
fnm envwill look forfnm_multishellson the environment variable$PATH.PATHvariable, thus preventing it to be duplicated.FNM_MULTISHELL_PATH(but stripes out the/bin)