Skip to content

[sitecore-jss-react] Extend withDatasourceCheck logic to handle empty datasource in DesignLibrary mode #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Apr 7, 2025

Description / Motivation

Components rendered within the Design Library don’t require a datasource and are initialized with an empty one by default. We need to handle this case explicitly to avoid unnecessary validation errors.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@illiakovalenko illiakovalenko merged commit 4faf933 into release/beta Apr 7, 2025
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/JSS-5768 branch April 7, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants