Skip to content

SwanseaUniversityMedical/renovate-34889

Repository files navigation

34889

Reproduction for Renovate discussion 34889.

Example renovate log file: https://github.com/SwanseaUniversityMedical/renovate-34889/blob/c3df1d33110939e8da6adecaad596c5d468880a0/SwanseaUniversityMedical_renovate-34889_2025-03-29_21-02_3a11656f-2ab4-4423-b0c7-c13eb8030dc9.log

Current behavior

With helpers:pinGitHubActionDigests enabled in the config I receive errors when renovate tries to pin suffixed dependencies.

We manage a monorepo of independently versioned github actions and reusable workflows. They are git-tagged with SemVer compliant suffixes such as v1.0.8-foobar-action and v3.0.0-bizzbuzz-action.

Renovate does a good job of updating these tags in most cases, but is failing when pinDigests is true.

This reproduction repo focuses around a github workflow that needs it's github actions to be bumped and also digest pinned. Namely

- uses: SwanseaUniversityMedical/renovate-34889/.github/actions/foobar@v1.0.0-foobar-action
with:
name: "foobar"
- uses: SwanseaUniversityMedical/renovate-34889/.github/actions/foobar@foobar-action-v1.0.0
with:
name: "prefix-foobar"
- uses: SwanseaUniversityMedical/renovate-34889/.github/actions/bizzbuzz@v1.0.0-bizzbuzz-action
with:
name: "bizzbuzz"
- uses: SwanseaUniversityMedical/renovate-34889/.github/actions/bizzbuzz@bizzbuzz-action-v1.0.0
with:
name: "prefix-bizzbuzz"

A workflows containing the following use of our action which needs to be pinned:

steps:
  - uses: my-org/workflows/.github/actions/foobar@v1.0.8-foobar-action

Yields the following renovates error logs:

DEBUG: Value is not updated (repository=my-org/workflows, packageFile=.github/workflows/workflows-foobar.yaml, branch=renovate/pin-dependencies)
       "depName": "my-org/workflows",
       "manager": "github-actions",
       "expectedValue": "v1.0.8-foobar-action",
       "foundValue": "v1.0.8"
 WARN: Error updating branch: update failure (repository=my-org/workflows, branch=renovate/pin-dependencies)

I can't see what renovate is doing to the file internally when this error is thrown, but it looks like it is probably outputting:

  - uses: my-org/workflows/.github/actions/foobar@abcdefgabcdefg # v1.0.8

Expected behavior

The expected output should faithfully preserve the git-tag suffix:

  - uses: my-org/workflows/.github/actions/foobar@abcdefgabcdefg # v1.0.8-foobar-action

Detected dependencies

github-actions
.github/workflows/workflows-run-actions.yaml
  • SwanseaUniversityMedical/renovate-34889 v1.0.0-foobar-action
  • SwanseaUniversityMedical/renovate-34889 v1.0.0-bizzbuzz-action

Link to the Renovate issue or Discussion

renovatebot/renovate#34889