Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map reprojection but better #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elastufka
Copy link

Changes:

  • minor bug fixes
  • added get_sdo_position() to get SDO trajectory information from drms
  • get_solo_position() and get_sdo_position() now return reference coordinates rather than observers. These contain more information that is needed by make_fitswcs_header() to correctly make the output header.
  • edited create_header() to only return new header accounting for reprojected cutout size (unnecessary to return both WCS and header)
  • edited reproject_map() to work with observer or reference coordinate, and to warn if desired reprojection is likely to take a long time/crash Python by trying to reproject to a very large array

Tests:

  • unable to run test in tests/ since stixcore.ephemeris doesn't exist publicly on GitHub
  • tested with STIX image -> AIA frame and vice versa using submaps, works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant