Skip to content

Update jsoncons trait #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

dmazzella
Copy link

a try to solve #371

@dmazzella
Copy link
Author

@prince-chrismc can please do a review?

@dmazzella dmazzella changed the title Update traits.h Update jsoncons trait Mar 23, 2025
Copy link
Collaborator

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small questions but looks really promising

@prince-chrismc
Copy link
Collaborator

Seems a type is wrong with the object subscription https://github.com/Thalhammer/jwt-cpp/actions/runs/14010395755/job/39397134923?pr=375#step:11:1748

@dmazzella
Copy link
Author

@prince-chrismc @Thalhammer can you take a look at it?

@prince-chrismc
Copy link
Collaborator

prince-chrismc commented Apr 14, 2025

This is a break but only for this implementation that has a different major. I think the changes to the example are acceptable

@prince-chrismc
Copy link
Collaborator

prince-chrismc commented Apr 14, 2025

Cmake v4 is not compatible. I'll make some time for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants