-
-
Notifications
You must be signed in to change notification settings - Fork 260
Update jsoncons trait #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@prince-chrismc can please do a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small questions but looks really promising
Seems a type is wrong with the object subscription https://github.com/Thalhammer/jwt-cpp/actions/runs/14010395755/job/39397134923?pr=375#step:11:1748 |
@prince-chrismc @Thalhammer can you take a look at it? |
This is a break but only for this implementation that has a different major. I think the changes to the example are acceptable |
Cmake v4 is not compatible. I'll make some time for this |
a try to solve #371