Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PeerJS Extension #1897

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Add PeerJS Extension #1897

wants to merge 25 commits into from

Conversation

MikeDev101
Copy link
Contributor

@MikeDev101 MikeDev101 commented Jan 29, 2025 •
edited
Loading

https://github.com/cloudlink-omega/peerjs-scratch

This was intended to be an experimental foundation for a CL5 rewrite but I thought it would be perfectly fine making it it's own thing.

I'm not 100% sure if my tweaks to the original code would make it fully compliant with the "Banned APIs" section.

@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Jan 29, 2025
@MikeDev101
Add missing "Name:" tag
a4a4d88
@MikeDev101
Tweak "By" and "Original" tags
c48a26e 
??????
@MikeDev101
Update peerjs.js
91cfc7f 
"Links to places other than Scratch are not allowed at this time"
@MikeDev101
Run Prettier
28705e9
@Thebloxers998
Copy link

PeerJS?! Your Adding It? Yayyyyyyyyyy

Thebloxers998
Thebloxers998 reviewed Feb 1, 2025
View reviewed changes
Copy link

@Thebloxers998 Thebloxers998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the best extension for multiplayer, nice 👍

@Thebloxers998
Copy link

Where is the create peer block

SharkPool-SP
SharkPool-SP requested changes Feb 3, 2025
View reviewed changes
@MikeDev101
Copy link
Contributor Author

Noted requested changes, will be working on them.

@CubesterYT
Copy link
Member

I'll do a review

CubesterYT
CubesterYT requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@CubesterYT CubesterYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round one of reviews

This extension is VERY weird.

CubesterYT
CubesterYT requested changes Feb 6, 2025
View reviewed changes
@CubesterYT
Copy link
Member

!format

@MikeDev101
Copy link
Contributor Author

huh, neat

@CubesterYT
Copy link
Member

huh, neat

Yeah, lol, it's a workflow I made (polished by GarboMuffin)

@MikeDev101
Copy link
Contributor Author

since we're here, can someone please fix the website's credit link to point to my new account? thanks

CubesterYT
CubesterYT requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@CubesterYT CubesterYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review from what I see.

I'd recommend making documentation, so people can have a better understanding on how to use this extension, but it isn't required.

I would like for others to review as well, in case I missed anything.

SharkPool-SP
SharkPool-SP requested changes Feb 6, 2025
View reviewed changes
@MikeDev101
Copy link
Contributor Author

let's see if this will work for me

@MikeDev101
Copy link
Contributor Author

MikeDev101 commented Feb 6, 2025 •
edited
Loading

!format

guess not.

spoke too soon?

@MikeDev101
Copy link
Contributor Author

I don't think I'm using Scratch.canRecordAudio() correctly - Is it awaitable or is it blocking?

@CST1229
Copy link
Collaborator

CST1229 commented Feb 6, 2025

I don't think I'm using Scratch.canRecordAudio() correctly - Is it awaitable or is it blocking?

it's async (so awaitable)

@MikeDev101
Await canRecordAudio
a734599
@MikeDev101
Minor tweaks
59b2b5d 
* Updated title
* Minified ULID function
* Prettier - Removed trailing commas
@MikeDev101
Copy link
Contributor Author

!format

@CubesterYT CubesterYT requested a review from CST1229 February 6, 2025 23:31
CubesterYT
CubesterYT requested changes Feb 6, 2025
View reviewed changes
@MikeDev101
Copy link
Contributor Author

😭

@MikeDev101 MikeDev101 requested a review from CubesterYT February 7, 2025 00:21
CubesterYT
CubesterYT requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@CubesterYT CubesterYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finale

CubesterYT
CubesterYT approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@CubesterYT CubesterYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, now we just wait on the others.

@SharkPool-SP
Copy link
Collaborator

Why does the block "enableVerboseLogs" exist even though the toggle logs block exists?

@CubesterYT
Copy link
Member

Why does the block "enableVerboseLogs" exist even though the toggle logs block exists?

He released this extension earlier to his own people, so technically, just like your extensions, they are already being used by real people, and he rather not break compatibility.

@SharkPool-SP
Copy link
Collaborator

Why does the block "enableVerboseLogs" exist even though the toggle logs block exists?

He released this extension earlier to his own people, so technically, just like your extensions, they are already being used by real people, and he rather not break compatibility.

Ah okay.

@SharkPool-SP
Copy link
Collaborator

Seems all good then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thebloxers998 Thebloxers998 Thebloxers998 left review comments

@CubesterYT CubesterYT CubesterYT approved these changes

@SharkPool-SP SharkPool-SP SharkPool-SP approved these changes

@GarboMuffin GarboMuffin Awaiting requested review from GarboMuffin

@CST1229 CST1229 Awaiting requested review from CST1229

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MikeDev101 @Thebloxers998 @CubesterYT @CST1229 @SharkPool-SP @GarboMuffin @DangoCat