Migrate Crashin' Thrashin' Battleship attempts on load #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This item had a typo in its name (extra parenthesis). While splitting the holiday events database, the typo was fixed. Unfortunately that means anyone who had attempts recorded under the old name would suddenly find them missing. The easy way around this would be to just restore the old name and leave it unchanged, forever. But there are some other items that would benefit from a migration system: Firstly, the "Big Love Rocket" is no longer named that, and then there's the manual "purge" command for Island Expedition items that never made it to live. Whether this approach is right, I've no idea. The migration logic is extremely basic so as to avoid destroying any data. Keeping in mind there are no tests for this yet, it does seem like the safest route. Eventually there may be tests and then this functionality can be extended. For now, I'd rather not mess with the DB internals any more than necessary, especially because many people don't seem to create any backups.
aSnejbjerg
approved these changes
Feb 28, 2025
rdw-software
added a commit
that referenced
this pull request
Feb 28, 2025
This typo was fixed when splitting the holiday items database, but previous attempts would have been stored under the old (incorrect) name. I don't have time to refine the WIP migration PR (#824) before the next release, so it's probably better to restore the original name and fix the database up properly later. Players will only see the localized name, which doesn't contain the typo. Fixing the name is of moderate utility at best and can be deferred. I'd rather not merge a somewhat half-baked DB migration feature before I've spent more time on refining and testing it.
rdw-software
added a commit
that referenced
this pull request
Feb 28, 2025
This typo was fixed when splitting the holiday items database, but previous attempts would have been stored under the old (incorrect) name. I don't have time to refine the WIP migration PR (#824) before the next release, so it's probably better to restore the original name for the time being, and take all the time needed to fix the database up properly later. Players will only see the localized name, which doesn't contain the typo. Fixing the name is of moderate utility at best and can be deferred. I'd rather not merge a half-baked DB migration feature before I've spent more time on refining and testing it.
rdw-software
added a commit
that referenced
this pull request
Feb 28, 2025
This typo was fixed when splitting the holiday items database (in b2b1f30), but previous attempts would have been stored under the old (incorrect) name. I don't have time to refine the WIP migration PR (#824) before the next release, so it's probably better to restore the original name for the time being, and take all the time needed to fix the database up properly later. Players will only see the localized name, which doesn't contain the typo. Fixing the name is of moderate utility at best and can be deferred. I'd rather not merge a half-baked DB migration feature before I've spent more time on refining and testing it.
|
Thanks for the review! I've decided to postpone adding this feature as it would benefit from more refinement (and testing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This item had a typo in its name (extra parenthesis). While splitting the holiday events database, the typo was fixed. Unfortunately that means anyone who had attempts recorded under the old name would suddenly find them missing.
The easy way around this would be to just restore the old name and leave it unchanged, forever. But there are some other items that would benefit from a migration system: Firstly, the "Big Love Rocket" is no longer named that, and then there's the manual "purge" command for Island Expedition items that never made it to live. Whether this approach is right, I've no idea.
The migration logic is extremely basic so as to avoid destroying any data. Keeping in mind there are no tests for this yet, it does seem like the safest route. Eventually there may be tests and then this functionality can be extended. For now, I'd rather not mess with the DB internals any more than necessary, especially because many people don't seem to create any backups.
Status: Shelved for now. Needs automated testing, which requires some other database work to be completed first.