[XDP] Better handle partition shifts in VE2 #8781
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
jvillarre
approved these changes
Feb 21, 2025
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Columns in shifted partitions are not reported correctly, hence, trace display is incorrect
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None
How problem was solved, alternative solutions (if any) and why they were rejected
Use relative columns with driver but shifted columns when reporting
Risks (if any) associated the changes in the commit
Differences still exist between zocl and HW context flows; need to be worked out in future PR
What has been tested and how, request additional testing if necessary
Tested on VE2 board
Documentation impact (if any)
Tile locations will be reported at shifted locations