-
Notifications
You must be signed in to change notification settings - Fork 486
Temporal Sharing Overhead test ELF flow (mobilenet) #8866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamesong <james.song@amd.com>
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Signed-off-by: jamesong <james.song@amd.com>
Signed-off-by: jamesong <james.song@amd.com>
aktondak
reviewed
Apr 10, 2025
src/runtime_src/core/tools/common/tests/TestValidateUtilities.cpp
Outdated
Show resolved
Hide resolved
aktondak
reviewed
Apr 10, 2025
src/runtime_src/core/tools/common/tests/TestValidateUtilities.cpp
Outdated
Show resolved
Hide resolved
…tValidateUtilities Signed-off-by: jamesong <james.song@amd.com>
Signed-off-by: jamesong <james.song@amd.com>
AShivangi
reviewed
Apr 11, 2025
aktondak
reviewed
Apr 11, 2025
src/runtime_src/core/tools/common/tests/TestTemporalSharingOvd.cpp
Outdated
Show resolved
Hide resolved
AShivangi
reviewed
Apr 11, 2025
…ording to comments Signed-off-by: jamesong <james.song@amd.com>
aktondak
approved these changes
Apr 11, 2025
AShivangi
approved these changes
Apr 11, 2025
stsoe
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Enable ELF flow for temporal sharing overhead (mobile net)
How problem was solved, alternative solutions (if any) and why they were rejected
Convert corresponding xclbin and dpu sequence files to modern xclbin and elf files. Change the workflow in test to ELF flow. Remove the DPU sequence flow.
What has been tested and how, request additional testing if necessary
Tested on Windows with MCDM using following command:
xrt-smi validate -r temporal-sharing-overhead --advanced