Skip to content

Feat (data): separating sequence and sentence BOS preprocessing #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Feat (data): separating sequence and sentence BOS preprocessing #1272

wants to merge 2 commits into from

Conversation

i-colbert
Copy link
Collaborator

@i-colbert i-colbert commented Apr 22, 2025 •
edited
Loading

Reason for this PR

See #1229 for detailed discussion on reason.

Changes Made in this PR

  • Separately considering sentence and sequence BOS pre-processing
  • Repurposing no_bos_preprocessing argument to bos_preprocessing
  • Making sure training and testing datasets are processed the same way

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@i-colbert i-colbert marked this pull request as draft April 22, 2025 17:00
@i-colbert i-colbert mentioned this pull request Apr 22, 2025
Open
@i-colbert i-colbert marked this pull request as ready for review April 23, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@i-colbert